Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge from d70b5db to 803d9d4 #1854

Merged
merged 11 commits into from
Feb 27, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 22, 2023

This PR "only" integrates twbs/bootstrap@d70b5db and twbs/bootstrap@803d9d4 to facilitate the review by isolating this new helper.
(integrated the second one to quickly fix the issue with the titles' color in the docs :p)

  • I reworked our documentation to move "Link chevron" directly to "Icon link" utility documentation. In order to treat the ODS incompatibility callout and make it understandable for Orange developers, I've put this chevron link first and the rest of the utility after (by adding one level of headings).
  • In "Icon link", I chose to keep Bootstrap icons and to explain that Orange developers should rather use Solaris icons instead if they need this utility.

Live previews

TODO

  • Add migration guide notes when the content of this PR will be satisfying

@julien-deramond julien-deramond added v5 merge Sync with Bootstrap skip:ci labels Feb 22, 2023
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-da1c968 branch from 8c10da3 to dbcfafb Compare February 22, 2023 09:06
Base automatically changed from main-jd-chore-merge-from-da1c968 to main February 22, 2023 09:09
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-d70b5db branch from a8890a6 to a90dbcc Compare February 22, 2023 09:10
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1c882e2
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63fcbc3d31b638000758a1ca
😎 Deploy Preview https://deploy-preview-1854--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-d70b5db branch from 006ac45 to acbd92a Compare February 22, 2023 12:03
@julien-deramond julien-deramond changed the title Chore merge from d70b5db Chore merge from 803d9d4 Feb 22, 2023
@julien-deramond
Copy link
Member Author

Haven't checked everything in detail, but this first draft seems OK.
/cc @louismaximepiton for feedback

@julien-deramond julien-deramond marked this pull request as ready for review February 22, 2023 13:24
@julien-deramond julien-deramond changed the title Chore merge from 803d9d4 Chore merge from d70b5db to 803d9d4 Feb 22, 2023
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to discuss before approving this one :)

scss/_root.scss Show resolved Hide resolved
75: .75,
100: 1
),
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bootstrap Side] Shouldn't we add some 0 values in here ? Or maybe add state: hover for text-decoration ? Might be Boosted side only to have links not underlined and underlined on hover ?

scss/helpers/_icon-link.scss Outdated Show resolved Hide resolved
scss/helpers/_icon-link.scss Show resolved Hide resolved
scss/helpers/_icon-link.scss Show resolved Hide resolved
site/content/docs/5.3/helpers/icon-link.md Outdated Show resolved Hide resolved
scss/helpers/_icon-link.scss Show resolved Hide resolved
site/content/docs/5.3/utilities/link.md Show resolved Hide resolved
site/content/docs/5.3/utilities/link.md Outdated Show resolved Hide resolved
site/content/docs/5.3/utilities/link.md Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit cc00acc into main Feb 27, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-d70b5db branch February 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Sync with Bootstrap v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants